Psd2 Verify Snippet #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonmantank
requested changes
Aug 31, 2020
|
I think the same thing happened here that happened in the vonage-java repo. I will get that sorted out. |
yallen011
force-pushed
the
psd2-verify-snippet
branch
from
7c24fba to
17186b5
Compare
slorello89
suggested changes
Sep 3, 2020
There was a problem hiding this comment.
Two things:
- Minor suggestion on perhaps explicitly calling out the builder pattern in the workflow snippet
- The README specifies that the package that's built for the code snippets is
nexmo-java-code-snippets-with-dependencies.jaron my machine it's buildingvonage-java-code-snippets-with-dependencies.jarIt might be the folder name I'm using? or is something else going on?
src/main/java/com/nexmo/quickstart/verify/StartPsd2VerificationWithWorkflow.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PSD2 code snippets.